Plot improvements: subplot_tracer_from_fit overhaul, line_colors, caustics#408
Merged
Plot improvements: subplot_tracer_from_fit overhaul, line_colors, caustics#408
Conversation
…stics - subplot_tracer_from_fit: compute critical curves and caustics before drawing panels so all source panels receive line overlays; add deflections Y/X and magnification to panels 6-8; use lens_galaxies.deflections_yx_2d_from for correct panel content - subplot_tracer: add critical curves (black=tangential, white=radial) and caustics; harden source image and source plane panels; add source_vmax scaling - _plot_source_plane: log exceptions instead of silently blanking the axis - plotter.py: remove standalone subplot_tracer call from tracer plotter (imaging plotter handles subplot_tracer via subplot_tracer_from_fit) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
subplot_tracer_from_fit: compute critical curves and caustics before drawing any panels so panels 0–2 (Model Image, Source Model Image, Source Plane) all receive line overlays; add Deflections Y/X and Magnification to panels 6–8; uselens_galaxies.deflections_yx_2d_frommatchinggalaxies.pngsubplot_tracer: add critical curves (black=tangential, white=radial) and caustics to all relevant panels; harden source image and source plane panels withsource_vmaxscaling_plot_source_plane: log exceptions vialogger.warninginstead of silently blanking the axis — makes failures visible in logsplotter.py: remove redundant standalonesubplot_tracercall from the tracer plotter (imaging plotter handlessubplot_tracerviasubplot_tracer_from_fit)Test plan
tracer.pngshows the correct Source Model Image (non-blank) in panel 1Could not plot source reconstructionwarnings if panels still blank🤖 Generated with Claude Code